Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix citybikes #22683

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Fix citybikes #22683

merged 1 commit into from
Apr 3, 2019

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Apr 3, 2019 •
edited
Loading

Breaking Change:

N/A

Description:

  • Move asyncio condition to instance from class, to be able to pass in
    loop.
  • Avoid not needed side effects in init methods.
  • Clean up.

Related issue (if applicable):
fixes #16523

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: citybikes
    network: velib
    stations:
      - 19008
  - platform: citybikes
    network: velib
    stations:
      - 19001

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@MartinHjelmare
Fix citybikes
ef24fae 
* Move asyncio condition to instance from class, to be able to pass in
  lopp.
* Avoid not needed sife effects in init methods.
* Clean up.
@ghost ghost assigned MartinHjelmare Apr 3, 2019
@ghost ghost added the in progress label Apr 3, 2019
@balloob balloob merged commit 3872ac9 into home-assistant:dev Apr 3, 2019
@ghost ghost removed the in progress label Apr 3, 2019
@MartinHjelmare MartinHjelmare deleted the fix-citybikes branch April 4, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MartinHjelmare MartinHjelmare

Labels
cla-signed integration: citybikes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Citybike sensor error
3 participants
@MartinHjelmare @balloob @homeassistant