Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove botocore dependency from credstash script #22511

Merged
merged 4 commits into from
Mar 28, 2019
Merged

Remove botocore dependency from credstash script #22511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e39cc4
Remove botocore dependency from credstash script
awarecan Mar 28, 2019
41d03e0
Update requirements_all.txt
awarecan Mar 28, 2019
fb11274
Update pylintrc
awarecan Mar 28, 2019
2eb38a6
Update credstash.py
awarecan Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions homeassistant/scripts/credstash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

from homeassistant.util.yaml import _SECRET_NAMESPACE

REQUIREMENTS = ['credstash==1.15.0', 'botocore==1.7.34']
REQUIREMENTS = ['credstash==1.15.0']


def run(args):
Expand All @@ -24,16 +24,15 @@ def run(args):
'value', help="The value to save when putting a secret",
nargs='?', default=None)

# pylint: disable=import-error, no-member
# pylint: disable=no-member
import credstash
import botocore

args = parser.parse_args(args)
table = _SECRET_NAMESPACE

try:
credstash.listSecrets(table=table)
except botocore.errorfactory.ClientError:
except Exception: # pylint: disable=broad-except
credstash.createDdbTable(table=table)

if args.action == 'list':
Expand Down
1 change: 0 additions & 1 deletion pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ reports=no
[TYPECHECK]
# For attrs
ignored-classes=_CountingAttr
generated-members=botocore.errorfactory

[FORMAT]
expected-line-ending-format=LF
Expand Down
3 changes: 0 additions & 3 deletions requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,6 @@ blockchain==1.4.4
# homeassistant.components.aws_sqs.notify
boto3==1.9.16

# homeassistant.scripts.credstash
botocore==1.7.34

# homeassistant.components.braviatv.media_player
braviarc-homeassistant==0.3.7.dev0

Expand Down