Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core services.yaml file to Home Assistant integration #22489

Merged
merged 2 commits into from
Mar 30, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Mar 28, 2019

Description:

This removes services.yaml in the root of the components directory, and removes the edge case handling that was there in the service helper.

@balloob balloob requested a review from a team as a code owner March 28, 2019 05:51
@ghost ghost assigned balloob Mar 28, 2019
@ghost ghost added the in progress label Mar 28, 2019
@balloob balloob changed the title Move core services.yaml file to Home Assistant integratino Move core services.yaml file to Home Assistant integration Mar 28, 2019
@balloob balloob force-pushed the move-services-homeassistant-component branch from 2903294 to 5d2dfc2 Compare March 28, 2019 17:31
Copy link
Member

@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. No tests needed updating?

@balloob
Copy link
Member Author

balloob commented Mar 30, 2019

Nope 👍 (which I thought was a bit weird too btw)

@balloob balloob merged commit 95a7077 into dev Mar 30, 2019
@ghost ghost removed the in progress label Mar 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the move-services-homeassistant-component branch March 30, 2019 03:48
unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019
…stant#22489)

* Move services.yaml to correct dir

* Remove special case for HA servicesgs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants