Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-tado version to 0.2.9 #22243

Closed
wants to merge 2 commits into from
Closed

Bump python-tado version to 0.2.9 #22243

wants to merge 2 commits into from

Conversation

thomasvt1
Copy link

@thomasvt1 thomasvt1 commented Mar 21, 2019

0.2.8 removed - https://pypi.org/project/python-tado/#history

Breaking Change:

Description:

0.2.8 version pulled

wmalgadey/PyTado#13

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels Mar 21, 2019
@ghost ghost added the in progress label Mar 21, 2019
@thomasvt1 thomasvt1 changed the title Fix python-tado version to 0.2.9 Bump python-tado version to 0.2.9 Mar 21, 2019
@vrnagy
Copy link
Contributor

vrnagy commented Mar 21, 2019

You should change the /homeassistant/components/tado/__init__.py component file itself as well. https://github.com/home-assistant/home-assistant/blob/77635d40e2cd3e633204303f05bb20c909daf383/homeassistant/components/tado/__init__.py#L13

@awarecan
Copy link
Contributor

We already have one pull request for it.

@awarecan awarecan closed this Mar 21, 2019
@ghost ghost removed the in progress label Mar 21, 2019
@egelmex
Copy link

egelmex commented Mar 21, 2019

What's the pull ID of the pull request that fixes this issue?

@vrnagy
Copy link
Contributor

vrnagy commented Mar 21, 2019

#22242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants