Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tado version #22145

Merged
merged 3 commits into from
Mar 18, 2019
Merged

Bump tado version #22145

merged 3 commits into from
Mar 18, 2019

Conversation

WebSpider
Copy link
Contributor

@WebSpider WebSpider commented Mar 17, 2019

Description:

Bump python-tado to 0.2.8, upstream version holds an API endpoint change
Change references from old endpoint to new one

Related issue (if applicable): fixes #22048

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • N/A New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • N/A New files were added to .coveragerc.

If the code does not interact with devices:

  • N/A Tests have been added to verify that the new code works.

@homeassistant

This comment has been minimized.

@ghost ghost added the in progress label Mar 17, 2019
@WebSpider
Copy link
Contributor Author

Linked email.

@homeassistant

This comment has been minimized.

@WebSpider WebSpider changed the title [WIP] Bump tado version Bump tado version Mar 18, 2019
@cgarwood cgarwood merged commit e14b243 into home-assistant:dev Mar 18, 2019
@ghost ghost removed the in progress label Mar 18, 2019
@cgarwood cgarwood added this to the 0.90.0 milestone Mar 18, 2019
z0mbieprocess pushed a commit to z0mbieprocess/home-assistant that referenced this pull request Mar 18, 2019
* Bump python-tado, new API endpoint

* Change references of old API endpoint to new

* Update REQUIREMENTS
balloob pushed a commit that referenced this pull request Mar 19, 2019
* Bump python-tado, new API endpoint

* Change references of old API endpoint to new

* Update REQUIREMENTS
@balloob balloob mentioned this pull request Mar 20, 2019
@h4nc
Copy link

h4nc commented Mar 21, 2019

Still doesn't work with 0.90

Tado doesn’t start up, from the logs:

Unable to connect to mytado with username and password

Setup failed for tado: Component failed to initialize.

@MartinHjelmare
Copy link
Member

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Mar 21, 2019
@WebSpider WebSpider deleted the bump_tado branch March 23, 2023 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tado component - stopped working
6 participants