Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort by config and tests for Reddit integration #22081

Merged
merged 6 commits into from
Mar 22, 2019

Conversation

ljmerza
Copy link
Contributor

@ljmerza ljmerza commented Mar 15, 2019

Breaking Change:

Description:

Adds sort by config to Reddit sensor and tests.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8952

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: reddit
    username: !secret reddit_username
    password: !secret reddit_password
    client_id: !secret reddit_client_id
    client_secret: !secret reddit_client_secret
    sort_by: new
    subreddits:
      - news
      - worldnews

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ljmerza ljmerza changed the title Reddit list type Reddit component - add sort by config and tests Mar 15, 2019
homeassistant/components/reddit/sensor.py Outdated Show resolved Hide resolved
@ljmerza ljmerza force-pushed the reddit-list-type branch 2 times, most recently from afcb0a5 to 819eea6 Compare March 19, 2019 12:51
@fabaff fabaff changed the title Reddit component - add sort by config and tests Add sort by config and tests for Reddit integration Mar 19, 2019
@ljmerza ljmerza force-pushed the reddit-list-type branch 2 times, most recently from a7b525a to 3c6bde0 Compare March 20, 2019 12:30
ljmerza added 6 commits March 20, 2019 12:39
add sort type to reddit sensor

automated commit 14/03/2019 15:53:15

automated commit 15/03/2019 09:43:39

reddit sensor add tests and sort by config

reddit sensor add tests and sort by config

reddit sensor add tests and sort by config

reddit sensor add tests and sort by config
@fabaff fabaff merged commit a58f1ee into home-assistant:dev Mar 22, 2019
@ghost ghost removed the in progress label Mar 22, 2019
@ljmerza ljmerza deleted the reddit-list-type branch March 23, 2019 03:57
@balloob balloob mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants