-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sort by config and tests for Reddit integration #22081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 15, 2019
houndci-bot
reviewed
Mar 15, 2019
ljmerza
force-pushed
the
reddit-list-type
branch
from
March 15, 2019 16:53
1f57f46
to
99299e8
Compare
ljmerza
changed the title
Reddit list type
Reddit component - add sort by config and tests
Mar 15, 2019
ljmerza
force-pushed
the
reddit-list-type
branch
from
March 15, 2019 19:03
99299e8
to
e34adb6
Compare
fabaff
requested changes
Mar 17, 2019
ljmerza
force-pushed
the
reddit-list-type
branch
2 times, most recently
from
March 19, 2019 12:51
afcb0a5
to
819eea6
Compare
fabaff
changed the title
Reddit component - add sort by config and tests
Add sort by config and tests for Reddit integration
Mar 19, 2019
ljmerza
force-pushed
the
reddit-list-type
branch
2 times, most recently
from
March 20, 2019 12:30
a7b525a
to
3c6bde0
Compare
add sort type to reddit sensor automated commit 14/03/2019 15:53:15 automated commit 15/03/2019 09:43:39 reddit sensor add tests and sort by config reddit sensor add tests and sort by config reddit sensor add tests and sort by config reddit sensor add tests and sort by config
ljmerza
force-pushed
the
reddit-list-type
branch
from
March 20, 2019 16:39
3c6bde0
to
f0cf270
Compare
fabaff
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
Adds sort by config to Reddit sensor and tests.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8952
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: