Refactor Waze Travel Time

[Petro31]

Refactored Waze Travel Time to contain a data object.

• Changed error retrieving data to a warning.
• Added distance conversion depending on region.
• Removed dependency on TRACKABLE_DOMAINS list.
• Update to use WazeRouteCalculator 0.10

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8825

Example entry for configuration.yaml (if applicable):

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[ljmerza]

Wanted to mention this PR #21153 gets rid of update for google_time_travel so probably be best to do that with waze as well. There's a discussion of getting rid of update on sensors home-assistant/architecture#131

[Petro31]

Wanted to mention this PR #21153 gets rid of update for google_time_travel so probably be best to do that with waze as well. There's a discussion of getting rid of update on sensors home-assistant/architecture#131

There is no update service for this component... nothing to remove.

[ljmerza]

how do the waze values get continuously updated without something triggering it?

I see hass.bus.listen_once(EVENT_HOMEASSISTANT_START, lambda _: sensor.update()) does this mean waze only gets updated on boot and that's it?

[Petro31]

how do the waze values get continuously updated without something triggering it?

I see hass.bus.listen_once(EVENT_HOMEASSISTANT_START, lambda _: sensor.update()) does this mean waze only gets updated on boot and that's it?

It gets updated through the update method. Like every other sensor. I believe you are confusing the update service with the update method.

To reenforce my reasoning, here is the expert that was removed from google_travel_time that is exactly what is being talked about.

        if DATA_KEY not in hass.data:	
            hass.data[DATA_KEY] = []	
            hass.services.register(	
                DOMAIN, 'google_travel_sensor_update', update)

Registering for a service. Not the fact that the component has an update method.

[ljmerza]

hey fyi someone is having an issue with UTF-8 decoding #21739

[mikeage]

It's not surprising, given the change, but I just took this PR locally, and confirmed the the UTF issue (really ISO-8859-1 decoding, I think) still fails.

[mikeage]

FWIW, replacing: self.route = bytes(route, 'ISO-8859-1').decode('UTF-8') with just self.route = route seems to work. I'm not terribly familiar with how python3 handles unicode, or why this conversion existed in the first place, so I'm not sure if this is right. But it did work for my routes :-)

edit: this seems like it was introduced in the last change to waze, which upgraded the wazeroutecalculator to a newer version that natively returns utf-8.

[Petro31]

FYI we may want to hold off on this PR until WazeRouteCalculator is fixed. There is a serious bug that affects Home Assistant users. The PR for it is: kovacsbalu/WazeRouteCalculator#37

[Petro31]

@pvizeli I'm unable to resolve merge conflicts due to access rights. This PR is ready in regards to WazeRouteCalculator updates.