-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Deprecate auto target all for services and introduce entity_id: * #19006
Conversation
Is step two, after deprecation period, to make entity_id required in all service schemas that target entity component services? |
Yeah |
Instead of |
Updated to match on word "all" |
b4984c0
to
6bfe294
Compare
home-assistant#19006) * Deprecate auto target all * Match on word 'all'
Maybe outline what a end user should be looking for. Not all users are savvy and just search and tweak existing examples. Here is an example automation script created and its generating the warning: Warning Message Automation Script
|
You're setting the volume of all your media players at the same time. You need to specify Also please do not post in merged PRs. |
Description:
If entity_id is omitted, we currently target all entities. That's pretty dangerous and for any installation that has more than 1 room in Home Assistant, useless and sometimes dangerous (like triggering all automations 🙈).
This PR:
entity_id: "all"
.We should not add support in the future to add regex or partial wildcards as that will remove the ability to statically analyse the config. And this is not the PR to discuss this either, related comments will be marked as off topic.
Pull request in home-assistant.io with documentation (if applicable): TODO
Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: