Remove since last boot from systemmonitor sensor #18644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: sensor.systemmonitor
small-pr
|
Correct me if I’m wrong but last_boot does not currently return a timestamp but a date. So we will lose information here |
|
Updated last_boot to be the full timestamp. If people want running time, home-assistant/architecture#39 is going to fix that. |
MartinHjelmare
approved these changes
Nov 23, 2018
2 tasks
2 tasks
frenck
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Nov 24, 2018
Merged
ghost
added
integration: systemmonitor
and removed
platform: sensor.systemmonitor
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We shouldn't store relative times in the state machine. We should only have
last_boot(which already exists) and give it the timestamp device class (is an architecture issue for), and then let the UI deal with updating it.