Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GTT Sensor #18449

Merged
merged 13 commits into from
Dec 17, 2018
Merged

Add GTT Sensor #18449

merged 13 commits into from
Dec 17, 2018

Conversation

eliseomartelli
Copy link
Contributor

@eliseomartelli eliseomartelli commented Nov 13, 2018 •
edited
Loading

Description:

Added a sensor to retrieve the next bus at the stop (from GTT, Gruppo Torinese Trasporti, the public transportation service of Turin, Italy)

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: gtt
    stop: '1080'
    bus: '58B'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

Pull request for documentation: #7504
If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@homeassistant
Copy link
Contributor

Hi @eliseomartelli,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Nov 13, 2018
houndci-bot
houndci-bot reviewed Nov 13, 2018
View reviewed changes
homeassistant/components/sensor/gtt.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/gtt.py Outdated Show resolved Hide resolved
@eliseomartelli eliseomartelli mentioned this pull request Nov 14, 2018
Merged
2 tasks
@eliseomartelli eliseomartelli changed the title added gtt sensor Added GTT Sensor Nov 14, 2018
MartinHjelmare
MartinHjelmare reviewed Dec 9, 2018
View reviewed changes
homeassistant/components/sensor/gtt.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/gtt.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/gtt.py Outdated Show resolved Hide resolved
homeassistant/components/sensor/gtt.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare changed the title Added GTT Sensor Add GTT Sensor Dec 14, 2018
@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@cgarwood cgarwood merged commit 6e26713 into home-assistant:dev Dec 17, 2018
@ghost ghost removed the in progress label Dec 17, 2018
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
@eliseomartelli @dshokouhi
Add GTT Sensor (home-assistant#18449)
13ee8f1 
* added gtt sensor

* removed trailing space

* updated requirements_all

* fixed two errors in the code style

* fixed imperative in docstring

* disabled pylint false positive

* fixed description on top of the file

* added files to .coveragerc

* fixes

* linting

* fixed linting 👍

* left a trailing space, now it's gone.

* fix
@balloob balloob mentioned this pull request Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludeeus ludeeus ludeeus left review comments

@houndci-bot houndci-bot houndci-bot left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: gtt new-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eliseomartelli @homeassistant @MartinHjelmare @houndci-bot @ludeeus @cgarwood