Improve Lutron RadioRA2 support, adding switches and scenes #18330
Conversation
- Update the version of pylutron to 0.2 which has various bug fixes. - Switch to pylutron's per-device subscribe - Add switch support, and configure any non-dimmable output as a switch. - Add scene support, using any configured keypad button with a corresponding LED as a scene.
ghost
added
the
| def device_state_attributes(self): | ||
| """Return the state attributes.""" | ||
| attr = {} | ||
| attr['Lutron Integration ID'] = self._lutron_device.id |
There was a problem hiding this comment.
Keys in state attributes should be lowercase snakecase.
There was a problem hiding this comment.
This was done to remain consistent with the existing light/lutron.py. I've updated the new switch code. I could update and include a fix for the light in this pull request as well.
There was a problem hiding this comment.
Could you make a separate PR with that correction for the light platform? It will be a breaking change. Thanks!
|
@pvizeli any other comments/requests? |
|
bump? |
MartinHjelmare
changed the title
…istant#18330) * Improve Lutron RadioRA2 support, adding switch and scene support. - Update the version of pylutron to 0.2 which has various bug fixes. - Switch to pylutron's per-device subscribe - Add switch support, and configure any non-dimmable output as a switch. - Add scene support, using any configured keypad button with a corresponding LED as a scene. * Fixes for comments in pull request home-assistant#18330 * More fixes for comments in pull request home-assistant#18330 * Remove unused imports * Cleanup in docstrings for Lutron scene support.
|
I've had problems crop up with lutron beginning in 0.85.1 -- so far no responses on my post: |
|
Please open an issue if you suspect a bug. If you need help please use our help channels: Merged PRs should not be used for support or bug reports. Thanks! |
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7444
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: