Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump NDMS2 client to 0.0.5 to fix unicode characters support #17803

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Bump NDMS2 client to 0.0.5 to fix unicode characters support #17803

merged 1 commit into from
Oct 26, 2018

Conversation

foxel
Copy link
Contributor

@foxel foxel commented Oct 26, 2018

Description:

NDMS2 client version 0.0.4 fails if user names device with unicode names, e.g. Cyrillic chars.
Fixed in 0.0.5: foxel/python_ndms2_client#1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost added the in progress label Oct 26, 2018
@foxel foxel changed the title Bumped NDMS2 client to 0.0.5 to fix unicode characters support Bump NDMS2 client to 0.0.5 to fix unicode characters support Oct 26, 2018
fabaff
fabaff approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 9e33398 into home-assistant:dev Oct 26, 2018
@ghost ghost removed the in progress label Oct 26, 2018
@foxel foxel deleted the bump_ndms_version_0.0.5 branch October 26, 2018 08:13
@balloob balloob mentioned this pull request Nov 9, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
cla-signed core Hacktoberfest integration: device_tracker small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foxel @fabaff @bachya @homeassistant