Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unavailable property when issue retrieving August information #17706

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Set unavailable property when issue retrieving August information #17706

merged 1 commit into from
Oct 23, 2018

Conversation

ehendrix23
Copy link
Contributor

@ehendrix23 ehendrix23 commented Oct 23, 2018

Description:

Sets the unavailable property for the entity if there is an issue when trying to retrieve the status for the August lock, sensor, and/or doorbells.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

Will set the available property to False if unable to communicate with August lock or doorbell.
HTTP request errors (i.e. timeout, connection error, HTTP error) will not result in traceback. Instead an error will be logged.
@balloob
Copy link
Member

balloob commented Oct 23, 2018

Nice 👍

@balloob balloob merged commit 4a757b7 into home-assistant:dev Oct 23, 2018
@ghost ghost removed the in progress label Oct 23, 2018
@ehendrix23 ehendrix23 deleted the Set-unavailable-property branch October 27, 2018 16:40
@balloob balloob mentioned this pull request Nov 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants