Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard for bad device info #17238

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Guard for bad device info #17238

merged 1 commit into from
Oct 8, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 8, 2018

Description:

Don't raise an exception if bad device info resulted in no device.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.80 milestone Oct 8, 2018
@balloob balloob requested a review from a team as a code owner October 8, 2018 09:02
@homeassistant homeassistant added core small-pr PRs with less than 30 lines. cla-signed labels Oct 8, 2018
@ghost ghost assigned balloob Oct 8, 2018
@ghost ghost added the in progress label Oct 8, 2018
@balloob balloob merged commit d5f5273 into dev Oct 8, 2018
@ghost ghost removed the in progress label Oct 8, 2018
@balloob balloob deleted the guard-for-bad-device-info branch October 8, 2018 10:53
balloob added a commit that referenced this pull request Oct 8, 2018
@balloob
Guard for bad device info (#17238)
2e12006
@balloob balloob mentioned this pull request Oct 12, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@balloob balloob

Labels
cherry-picked cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.80
Development

Successfully merging this pull request may close these issues.
2 participants
@balloob @homeassistant