MyQ cover return unknown state if not available #17207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
platform: cover.myq
small-pr
ghost
added
the
MartinHjelmare
requested changes
Oct 7, 2018
| 'opening': STATE_OPENING, | ||
| 'stopped': STATE_STOPPED, | ||
| 'transition': STATE_TRANSITION, | ||
| 'unknown': STATE_UNKNOWN |
There was a problem hiding this comment.
Don't use STATE_UNKNOWN. Use None to represent unknown state.
There was a problem hiding this comment.
Makes sense, thanks for the help.
MartinHjelmare
requested changes
Oct 7, 2018
| @@ -21,11 +21,16 @@ | |||
|
|
|||
| DEFAULT_NAME = 'myq' | |||
|
|
|||
| STATE_STOPPED = 'stopped' | |||
There was a problem hiding this comment.
Only states defined in the base cover component are allowed.
| @@ -128,4 +133,4 @@ def unique_id(self): | |||
|
|
|||
| def update(self): | |||
| """Update status of cover.""" | |||
| self._status = self.myq.get_status(self.device_id) | |||
| self._status = MYQ_TO_HASS.get(self.myq.get_status(self.device_id)) | |||
There was a problem hiding this comment.
self._status should represent the myq state not the home assistant state.
|
Can be merged when PR description is updated to latest changes and build passes. |
schmittx
changed the title
|
Updated title and description, thanks for the help on this! |
balloob
pushed a commit
that referenced
this pull request
Oct 8, 2018
* Add additional supported states * Use get method for lookup * Return None if unable to get status
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Nonerather than assumeSTATE_CLOSEDSTATE_UNKNOWNif unable to update statusRelated issue (if applicable): related to, but doesn't directly fix #16885
Pull request in home-assistant.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):N/AChecklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: