Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device tracking for the BT Smart Hub router #17158

Merged
merged 22 commits into from
Oct 23, 2018
Merged

Add device tracking for the BT Smart Hub router #17158

merged 22 commits into from
Oct 23, 2018

Conversation

jxwolstenholme
Copy link
Contributor

@jxwolstenholme jxwolstenholme commented Oct 5, 2018

Description:

Added support for device tracking for the BT Smart Hub router (UK). Might it be sensible to collect this with the bt_home_hub_5 component in some way - perhaps to share a page on home-assistant.io ?

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6528

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
device_tracker:
  - platform: bt_smarthub
    host: 192.168.1.254

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @jxwolstenholme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant
Copy link
Contributor

Hi @jxwolstenholme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant
Copy link
Contributor

Hi @jxwolstenholme,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@MartinHjelmare MartinHjelmare changed the title Adding support for device tracking for the BT Smart Hub router Add device tracking for the BT Smart Hub router Oct 11, 2018
@ghost ghost assigned fabaff Oct 13, 2018

import homeassistant.helpers.config_validation as cv
from homeassistant.components.device_tracker import (DOMAIN,
PLATFORM_SCHEMA, DeviceScanner)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (84 > 79 characters)

import voluptuous as vol

import homeassistant.helpers.config_validation as cv
from homeassistant.components.device_tracker import (DOMAIN,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

@MartinHjelmare MartinHjelmare merged commit 7be7a8d into home-assistant:dev Oct 23, 2018
@ghost ghost removed the in progress label Oct 23, 2018
@balloob balloob mentioned this pull request Nov 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants