Fix zoneminder zms_url construction #17150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: zoneminder
small-pr
ghost
added
the
MartinHjelmare
approved these changes
Oct 5, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
After the massive component refactor in #16527, there was a bug in the zoneminder component where the
zms_urlwas built by combining thepathwith thepath_zmswhich is incorrect since thepath_zmsshould be everything needed to get the correct path.This was fixed in the upstream library (rohankapoorcom/zm-py#16) which is upgraded in this PR.
Related issue (if applicable): fixes #17031
Checklist:
tox. Your PR cannot be merged unless tests pass