-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows multiple Netdata elements per group #16656
Conversation
The |
Breaking change: sensor:
- platform: netdata
host: 192.168.1.89
resources:
Download:
data_group: snmp_router.bandwidth_eth0
element: in
icon: mdi:download
Upload:
data_group: snmp_router.bandwidth_eth0
element: out
icon: mdi:upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🐦
Description:
Current Netdata component sensor configuration syntax only allows for one element per group.
This is an issue as this it is often needed to manage two different element at the same time, eg: download and upload for one network interface.
Related issue (if applicable): ref #14897 Called for a PR on that particular issue.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6296
Example entry for
configuration.yaml
(if applicable):Current syntax:
Doesn't work because of the duplicated
snmp_router.bandwidth_eth0
key.New syntax:
The previous
name
option is now mandatory and used as the key. As the name is used as part of the friendly name of the sensor, I'm not 100% sure if this is the right way to do it and I would like confirmation on that point.Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: