Track refresh token last usage information #16408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Sep 4, 2018
homeassistant/auth/__init__.py
Outdated
| @@ -277,8 +277,11 @@ def get_auth_mfa_module(self, module_id: str) \ | |||
|
|
|||
| @callback | |||
| def async_create_access_token(self, | |||
| refresh_token: models.RefreshToken) -> str: | |||
| refresh_token: models.RefreshToken, | |||
| used_by: Optional[str] = None) -> str: | |||
There was a problem hiding this comment.
Can we rename last_used_by to last_used_ip just so it's more descriptive
balloob
reviewed
Sep 4, 2018
homeassistant/auth/auth_store.py
Outdated
| @@ -224,7 +236,10 @@ def __init__(self, hass: HomeAssistant) -> None: | |||
| access_token_expiration=timedelta( | |||
| seconds=rt_dict['access_token_expiration']), | |||
| token=rt_dict['token'], | |||
| jwt_key=rt_dict['jwt_key'] | |||
| jwt_key=rt_dict['jwt_key'], | |||
| last_used_at=dt_util.parse_datetime(last_used_at_str) | |||
There was a problem hiding this comment.
I'm not a fan of inline if-statements that wrap two lines.
awarecan
force-pushed
the
extend-refresh-token-attr
branch
from
cdf3f7f
to
a63a6eb
Compare
houndci-bot
reviewed
Sep 4, 2018
homeassistant/auth/auth_store.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| """Storage for auth models.""" | |||
| from collections import OrderedDict | |||
| from datetime import timedelta | |||
| from datetime import timedelta, datetime | |||
There was a problem hiding this comment.
'datetime.datetime' imported but unused
awarecan
force-pushed
the
extend-refresh-token-attr
branch
from
a63a6eb
to
a96326b
Compare
awarecan
changed the title
balloob
approved these changes
Sep 12, 2018
|
I forgot about this PR 😨 |
balloob
force-pushed
the
extend-refresh-token-attr
branch
from
a96326b
to
f097fab
Compare
balloob
pushed a commit
that referenced
this pull request
Sep 12, 2018
* Extend refresh_token to support last_used_at and last_used_by * Address code review comment * Remove unused code * Add it to websocket response * Fix typing
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add
last_used_at(datetime) andlast_used_by(IP address string) fields torefresh_tokenRelated issue (if applicable): fixes #15196
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: