Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hangouts.users state, simplifies hangouts.conversations #16191

Merged
merged 1 commit into from
Aug 26, 2018
Merged

remove hangouts.users state, simplifies hangouts.conversations #16191

merged 1 commit into from
Aug 26, 2018

Conversation

hobbypunk90
Copy link
Contributor

@hobbypunk90 hobbypunk90 commented Aug 25, 2018

Description:

removes the hangouts.users state, it is nice to read for devs, but completely useless for users and confusing.
simplifies the hangouts.conversations, its reduced to the the id and name and a list of usernames of the conversation.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Aug 25, 2018
@balloob balloob added this to the 0.77 milestone Aug 26, 2018
@balloob
Copy link
Member

balloob commented Aug 26, 2018

Please open a PR for the docs and ask in description to add milestone 77 to it.

@balloob balloob merged commit d166f2d into home-assistant:dev Aug 26, 2018
@ghost ghost removed the in progress label Aug 26, 2018
@hobbypunk90
Copy link
Contributor Author

@balloob what do you mean? There is a pr for the hangouts doc, only the question for milestone 77 is missing.
I only have to add "pls add milestone 77" to description? 😁

@balloob
Copy link
Member

balloob commented Aug 27, 2018

I don't see a docs PR linked to this or? It's important you include link in docs PR to this PR and vice versa so they show linked. Makes my life easier

@hobbypunk90
Copy link
Contributor Author

I don't added it, because I had it in the first pr for hangouts and this pr don't change anything at the doc.
home-assistant/home-assistant.io#6044

@balloob
Copy link
Member

balloob commented Aug 27, 2018

Ah, didn't realize the original one wasn't merged yet. ok!

@balloob balloob mentioned this pull request Aug 29, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants