Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to intermediate Mozilla cert profile #15957

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Aug 13, 2018

Description:

Allow users to downgrade the SSL profile to the Mozilla Intermediate SSL profile.

Modern profile was too modern for certain integrations that interact with the Home Assistant API. Sadly, because the error happens when setting up the connection, it's not easy to figure out the source integration.

Related issue (if applicable):
fixes #15538
fixes #15579

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6013

Example entry for configuration.yaml (if applicable):

http:
  ssl_profile: intermediate

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.76 milestone Aug 13, 2018
@balloob balloob requested a review from a team as a code owner August 13, 2018 12:17
@ghost ghost assigned balloob Aug 13, 2018
@ghost ghost added the in progress label Aug 13, 2018
@fabaff fabaff changed the title Switch to intermediate Mozilla cert profile" Switch to intermediate Mozilla cert profile Aug 13, 2018
Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balloob balloob merged commit 6540d2e into dev Aug 14, 2018
@ghost ghost removed the in progress label Aug 14, 2018
@Chimichanga-II
Copy link

Chimichanga-II commented Aug 14, 2018

You guys are great! Been looking at this with awe.
Sorry, i am a very unexperienced. First time Github.
Would be great if someone could help me just a little.

Is this solution ready to implement?
I understand that i need to allow choosing of the ssl profile.
But how can i change / add the files, mentioned in the 'files changed' (4) section?
Or is this still dev work, and can i better wait till the official HA Core review.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Aug 14, 2018
@balloob balloob deleted the server-ssl-intermediate branch August 14, 2018 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL handshake failed Meraki Device Tracker SSL Error
5 participants