Hass.io sent token to supervisor #15536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
houndci-bot
reviewed
Jul 18, 2018
tests/components/hassio/test_init.py
Outdated
| aioclient_mock.get( | ||
| "http://127.0.0.1/homeassistant/info", json={ | ||
| 'result': 'ok', 'data': {'last_version': '10.0'}}) | ||
|
|
||
| @asyncio.coroutine |
tests/components/hassio/test_init.py
Outdated
| @asyncio.coroutine | ||
| def test_setup_api_ping(hass, aioclient_mock): | ||
| """Test setup with API ping.""" | ||
| @pytest.fixture(autouse=True) |
pvizeli
reviewed
Jul 18, 2018
| else: | ||
| token = None | ||
|
|
||
| yield from hassio.update_hass_api(config.get('http', {}), token) |
There was a problem hiding this comment.
Do we want migrate it to await?
|
@pvizeli for supervisor support, it looks like the supervisor won't allow unused options to be sent in. I think that we should change that so that it's easier to develop new features. I would like this change to go out on Friday, however right now it will break sending data to the supervisor. Would you be fine with adding an |
balloob
changed the title
pvizeli
approved these changes
Jul 19, 2018
balloob
changed the title
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
Hass.io sent token to supervisor
Merged
|
This commit why hass.io tab gets a blank white page now? |
|
@thecodingcheese Please do not use PR's to raise issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Have the Hass.io component create a system user and share a refresh token with the supervisor on startup. It will only generate it once and sent the same refresh token on each start.
The supervisor can use this token to fetch an access token to allow add-ons to access the Home Assistant API. In the future we might extend this to be a system account per add-on that wants access.
If the auth system is not active, the refresh token value is set to
null.Blocked by release of home-assistant/supervisor#575
CC @pvizeli
Related issue (if applicable): fixes #15220
Example entry for
configuration.yaml(if applicable):hassio:Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: