Update color.py to prevent ZeroDivisionError #15305
Conversation
To prevent the ZeroDivisionError listed #13381 I suggest this change to check if the value is bigger then 0 before making a division in line 469 and 476. Only thing I'm not sure about is wether the functions are expected to return something so maybe an 'else' clause should be included returning null or 0 ?
|
Hi @bartnaaijkens, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
ghost
added
the
| return math.floor(1000000 / mired_temperature) | ||
| if mired_temperature > 0: | ||
| return math.floor(1000000 / mired_temperature) | ||
|
|
There was a problem hiding this comment.
That is only a workaround and don't fix the problem:
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/google_assistant/trait.py#L314-L325
Please fix the problem on root.
|
Diving a bit deeper into this issue I found that the root cause is that the Deconz Component is setting the color_temp to 0 for groups exposed as lights. In Deconz there is a concept of a group of lights (https://dresden-elektronik.github.io/deconz-rest-doc/groups/#getattr) that will be exposed in HA as a light (https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/light/deconz.py). If 1 or more lights in a group have a color temperature and are switched on, the exposed group light will also get this attribute but it will be 0. (it does however allow you to set a color temperature to a group that will be forwarded to all lights in the group that support a color temperature. I am unsure what would be the right place to fix this. In Deconz component? In trait.py? Or still in color_util.py? If 0 mired would translate to 0 kelvin and HA should be able to deal with 0 color_temperature values in general I believe this could be the right place to fix it but then return 0 in case the input is 0. Or should the component never set the color_temp to 0? Hope above makes sense. I'm new to Github and HA so be patient with me :) |
|
This should be fixed in Deconz. 0 is not a valid color temp. CC @Kane610 |
Description:
To prevent a ZeroDivisionError I suggest this change to check if the value is bigger then 0 before making a division in line 469 and 476.
Only thing I'm not sure about is wether the functions are expected to return something so maybe an 'else' clause should be included returning null or 0 ?
Related issue (if applicable): fixes #
#13381
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: