Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Homee brightness sensors reporting in percent #139409

Merged
merged 12 commits into from
Mar 4, 2025

Conversation

Taraman17
Copy link
Contributor

@Taraman17 Taraman17 commented Feb 27, 2025

Proposed change

There are brightness sensors in Homee, that report their value in percent.
Since HA only supports lx for these, we have to work around that - brightness sensors reporting % will get no device_class.

Removed corresponding test, since it is covered by snapshots

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Feb 28, 2025
@MartinHjelmare MartinHjelmare changed the title Homee fix brightness sensors reporting in percent, remove valve position. Fix Homee brightness sensors reporting in percent, remove valve position Feb 28, 2025
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 28, 2025 23:23
@Taraman17 Taraman17 changed the title Fix Homee brightness sensors reporting in percent, remove valve position Fix Homee brightness sensors reporting in percent Mar 1, 2025
@Taraman17 Taraman17 marked this pull request as ready for review March 1, 2025 14:14
@home-assistant home-assistant bot requested a review from MartinHjelmare March 1, 2025 14:14
@MartinHjelmare MartinHjelmare marked this pull request as draft March 2, 2025 10:19
@Taraman17 Taraman17 marked this pull request as ready for review March 2, 2025 14:46
@home-assistant home-assistant bot requested a review from MartinHjelmare March 2, 2025 14:46
@MartinHjelmare MartinHjelmare marked this pull request as draft March 2, 2025 15:23
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Mar 2, 2025
@Taraman17 Taraman17 marked this pull request as ready for review March 2, 2025 16:40
@home-assistant home-assistant bot requested a review from MartinHjelmare March 2, 2025 16:40
@MartinHjelmare MartinHjelmare marked this pull request as draft March 2, 2025 17:55
@MartinHjelmare
Copy link
Member

Two questions remain. Otherwise it looks good.

@Taraman17 Taraman17 marked this pull request as ready for review March 2, 2025 18:50
@MartinHjelmare
Copy link
Member

One question remaining.

@MartinHjelmare MartinHjelmare marked this pull request as draft March 2, 2025 19:59
@Taraman17 Taraman17 marked this pull request as ready for review March 2, 2025 22:15
@MartinHjelmare MartinHjelmare marked this pull request as draft March 4, 2025 05:46
@MartinHjelmare MartinHjelmare marked this pull request as ready for review March 4, 2025 10:33
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2025.3.0 milestone Mar 4, 2025
@MartinHjelmare MartinHjelmare merged commit 23dac39 into home-assistant:dev Mar 4, 2025
32 checks passed
frenck pushed a commit that referenced this pull request Mar 4, 2025
* fix brigtness sensor having percent as unit.

* add test for percent-brightness-sensor

* remove valve position and update tests

* Removed test, because covered by Snapshots

* fix review comments

* move device calss to init.

* fix test

* fix review comments

* add battery sensor back to test fixture

* fix
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
@Taraman17 Taraman17 deleted the brightness-percent branch March 6, 2025 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants