Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stookwijzer==1.5.8 #139258

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

fwestenberg
Copy link
Contributor

Breaking change

https://github.com/fwestenberg/stookwijzer/compare/v1.5.4..v1.5.8

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fwestenberg 👍

@bdraco
Copy link
Member

bdraco commented Feb 25, 2025

test failure is unrelated
FAILED tests/components/logbook/test_websocket_api.py::test_live_stream_with_one_second_commit_interval - assert 7 == 8

@bdraco
Copy link
Member

bdraco commented Feb 25, 2025

Thanks @fwestenberg

@bdraco bdraco merged commit 776501f into home-assistant:dev Feb 25, 2025
41 of 42 checks passed
@thecode
Copy link
Member

thecode commented Feb 25, 2025

@bdraco
Copy link
Member

bdraco commented Feb 25, 2025

Let's revert. It looks like the dep can't be built without an external dependencies installed

bdraco added a commit that referenced this pull request Feb 25, 2025
@fwestenberg
Copy link
Contributor Author

fwestenberg commented Feb 25, 2025

Can somebody help me what's going wrong here? This URL explains the installation process, but I don't know what to do next. https://pyproj4.github.io/pyproj/stable/installation.html

@bdraco
Copy link
Member

bdraco commented Feb 26, 2025

It looks like this package needs proj installed before it will build

https://pkgs.alpinelinux.org/package/edge/community/x86/proj

That would require adding proj to everyone's image via adding it to the apk list in .github/workflows/wheels.yml

Is there perhaps a lighter weight library you could use instead?

@fwestenberg fwestenberg deleted the Bump-stookwijzer==1.5.8 branch February 26, 2025 08:58
@fwestenberg
Copy link
Contributor Author

fwestenberg commented Feb 26, 2025

It looks like this package needs proj installed before it will build

https://pkgs.alpinelinux.org/package/edge/community/x86/proj

That would require adding proj to everyone's image via adding it to the apk list in .github/workflows/wheels.yml

Is there perhaps a lighter weight library you could use instead?

I finally ended up calculating the X and Y locally. So no libraries anymore. 👍
#139332

@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not setup Stookwijzer integration
4 participants