Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homee number platform #138962

Merged
merged 11 commits into from
Feb 25, 2025
Merged

Add Homee number platform #138962

merged 11 commits into from
Feb 25, 2025

Conversation

Taraman17
Copy link
Contributor

@Taraman17 Taraman17 commented Feb 20, 2025

Breaking change

Proposed change

Add the number platform to homee integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to press the button

@home-assistant home-assistant bot marked this pull request as draft February 21, 2025 12:25
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Taraman17 Taraman17 marked this pull request as ready for review February 22, 2025 16:47
@MartinHjelmare MartinHjelmare changed the title Homee: add number platform Add Homee number platform Feb 22, 2025
# Conflicts:
#	tests/components/homee/test_sensor.py
@joostlek joostlek merged commit 3059d06 into home-assistant:dev Feb 25, 2025
28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
@Taraman17 Taraman17 deleted the homee_number branch February 27, 2025 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants