Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-roborock to 2.11.1 #137244

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Bump python-roborock to 2.11.1 #137244

merged 2 commits into from
Feb 3, 2025

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented Feb 3, 2025

Breaking change

Proposed change

Changes: Python-roborock/python-roborock@v2.9.7...v2.11.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Feb 3, 2025

Hey there @Lash-L, @allenporter, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@regevbr regevbr mentioned this pull request Feb 3, 2025
19 tasks
@Lash-L
Copy link
Contributor

Lash-L commented Feb 3, 2025

Hi - please add the following to your PR:

Changes: Python-roborock/python-roborock@v2.9.7...v2.11.0

@regevbr
Copy link
Contributor Author

regevbr commented Feb 3, 2025

Hi - please add the following to your PR:

Changes: Python-roborock/[email protected]

done

@Lash-L
Copy link
Contributor

Lash-L commented Feb 3, 2025

@home-assistant rename Bump python-roborock to 2.11.0

@home-assistant home-assistant bot changed the title feature: upgrade python-roborock Bump python-roborock to 2.11.0 Feb 3, 2025
@regevbr
Copy link
Contributor Author

regevbr commented Feb 3, 2025

@Lash-L do not merge yet, we need to fix a type issue in the lib first will handle PR now

@regevbr regevbr marked this pull request as draft February 3, 2025 14:23
@regevbr regevbr changed the title Bump python-roborock to 2.11.0 Bump python-roborock to 2.11.1 Feb 3, 2025
@regevbr regevbr marked this pull request as ready for review February 3, 2025 14:51
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @regevbr 👍

@edenhaus edenhaus added this to the 2025.2.0 milestone Feb 3, 2025
@edenhaus edenhaus merged commit a5eda3f into home-assistant:dev Feb 3, 2025
46 checks passed
frenck pushed a commit that referenced this pull request Feb 4, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants