Always include SSL folder in backups

[emontnemery]

Proposed change

Always include SSL folder in backups which include home assistant settings

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[frenck]

Thanks, @emontnemery 👍

../Frenck

[agners]

Always include SSL folder in backups which include home assistant settings

I guess we want the reverse too, as in include SSL folder when restoring Core settings? From quickly glancing at the code it seems that code is affecting backup path only, but maybe I am wrong on that? 🤔

[frenck]

Always include SSL folder in backups which include home assistant settings

I guess we want the reverse too, as in include SSL folder when restoring Core settings? From quickly glancing at the code it seems that code is affecting backup path only, but maybe I am wrong on that? 🤔

Agreed, however, on restore that might be a choice. This is being looked at (especially when doing a partial restore).

Right now, we don't back it up at all (this was missed), which is an issue. With a full restore on a new system or a plain system after a full hardware failure, having this missing is not nice.

With that in mind, this is a step forward we can fix/ship in a patch.

../Frenck

[frenck]

The CI error isn't related, therefore I'm moving forward with this merge.

../Frenck