Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peblar to v0.3.2 #134524

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Update peblar to v0.3.2 #134524

merged 1 commit into from
Jan 3, 2025

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 3, 2025

Proposed change

Updates peblar to v0.3.2
Release notes: https://github.com/frenck/python-peblar/releases/tag/v0.3.2
Diff: frenck/python-peblar@v0.3.1...v0.3.2

This PR bumps the dependency and the code. The code change is needed for this bump and thus coupled in the same PR.

Potentially addresses #134022 with the following:

  • White-labeled products may seem to have no customization firmware part
  • There seem to be cases where source parameters exist but have an empty string.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck
Copy link
Member Author

frenck commented Jan 3, 2025

The CI failure is a timeout on the VoIP integration and, thus, is not related to this PR. Will go ahead with the merge.

../Frenck

@frenck frenck merged commit 06580ce into dev Jan 3, 2025
60 of 61 checks passed
@frenck frenck deleted the frenck-2025-0007 branch January 3, 2025 09:37
available_fn=lambda x: x.available.customization,
has_fn=lambda x: x.current.customization is not None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems has_fn is not implemented in async_setup_entry. You plan that to do that in a follow-up or did you miss that accidentally?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 That is a miss

frenck added a commit that referenced this pull request Jan 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants