Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check vehicle metadata #134381

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Check vehicle metadata #134381

merged 2 commits into from
Jan 1, 2025

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Jan 1, 2025

Proposed change

Beta bugfix

There is an edge case where a user doesn't have a paid subscription covering all their vehicles will cause the setup to fail. Previously it would just cause the coordinator to fail, but other changes introduced in 2025.1 now run first refresh at setup.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@home-assistant
Copy link

home-assistant bot commented Jan 1, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 1, 2025 10:39
@Bre77 Bre77 force-pushed the t-vehiclemetadata branch from d4d5743 to d073e74 Compare January 1, 2025 11:03
@Bre77
Copy link
Contributor Author

Bre77 commented Jan 1, 2025

Tests are failing

Gahh sorry, I missed a file. Should be good to go shortly.

@Bre77 Bre77 marked this pull request as ready for review January 1, 2025 11:07
@home-assistant home-assistant bot requested a review from joostlek January 1, 2025 11:07
@joostlek joostlek merged commit 513c848 into home-assistant:dev Jan 1, 2025
34 checks passed
@gjohansson-ST gjohansson-ST added this to the 2025.1.0 milestone Jan 1, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants