Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate call to async_register_preload_platform #133909

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 23, 2024

Proposed change

integration_platform had two calls to this function, likely due to a back merge conflict resolution. It did not hurt anything other than it was a bit slower.

Tagged for milestone to avoid future conflicts

discovered while investigating #133904

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

integration_platform had two calls to this function, likely
due to a back merge conflict resolution. It did not hurt anything
other than it was a bit slower
@bdraco bdraco added this to the 2025.1.0 milestone Dec 23, 2024
@bdraco bdraco requested a review from a team as a code owner December 23, 2024 18:33
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels Dec 23, 2024
@bdraco
Copy link
Member Author

bdraco commented Dec 23, 2024

Thanks

@bdraco bdraco merged commit 7cfbc3e into dev Dec 23, 2024
64 checks passed
@bdraco bdraco deleted the dupe_async_register_preload_platform branch December 23, 2024 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants