Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound mode support to Onkyo #133531

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

arturpragacz
Copy link
Contributor

@arturpragacz arturpragacz commented Dec 18, 2024

Proposed change

Add sound mode support to Onkyo

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @eclair4151, mind taking a look at this pull request as it has been labeled with an integration (onkyo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of onkyo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign onkyo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@arturpragacz arturpragacz force-pushed the onkyo/sound-mode branch 2 times, most recently from 62c2193 to a12bf61 Compare January 24, 2025 17:45
@arturpragacz arturpragacz marked this pull request as ready for review January 24, 2025 17:49
@janstadt
Copy link

@arturpragacz are there any updates on this PR?

@arturpragacz
Copy link
Contributor Author

It is waiting for review.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft February 25, 2025 13:13
@arturpragacz arturpragacz marked this pull request as ready for review February 25, 2025 16:18
@home-assistant home-assistant bot requested a review from joostlek February 25, 2025 16:18
@joostlek joostlek merged commit 38cc264 into home-assistant:dev Feb 25, 2025
28 checks passed
@arturpragacz arturpragacz deleted the onkyo/sound-mode branch February 25, 2025 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants