Add sensors platform to Watergate integration #133015
Conversation
|
For reviewers: I left two questions in the code, because it is kinda weird for me and I do not want to reinvent a wheel if you think I should do it in a different way. |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
| coordinator, | ||
| FLOW_SENSOR_NAME, | ||
| FLOW_ENTITY_NAME, | ||
| lambda data: (data.telemetry.flow / 1000) |
There was a problem hiding this comment.
I think if you use unit_of_measurement and native_unit_of_measurement HA will do the transformation for you.
There was a problem hiding this comment.
Well there is no MILLILITERS_PER_MINUTE, so probably transformation will not work that easy, do you want me to include this new unit in this PR?
adam-the-hero
force-pushed
the
add-watergate-sensors-to-integration
branch
from
ca4e537 to
e18f266
Compare
adam-the-hero
force-pushed
the
add-watergate-sensors-to-integration
branch
from
e18f266 to
0a0cd9e
Compare
… handlers in entity.
… handlers in entity. Rename uptime entities to up since.
|
I would like to say sorry for being pain in the neck with all those bad stuff you are discovering here but I am learning the whole eco system. Thanks for keeping the high quality of the whole code. |
Breaking change
Proposed change
Adding additional entities for Watergate integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: