-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HEOS quality scale #132311
Merged
Merged
Add HEOS quality scale #132311
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
rules: | ||
# Bronze | ||
action-setup: | ||
status: todo | ||
comment: Future enhancement to move custom actions for login/out into an options flow. | ||
appropriate-polling: | ||
status: done | ||
comment: Integration is a local push integration | ||
brands: done | ||
common-modules: todo | ||
config-flow-test-coverage: | ||
status: todo | ||
comment: | ||
1. The config flow is 100% covered, however some tests need to let HA create the flow | ||
handler instead of doing it manually in the test. | ||
2. We should also make sure every test ends in either CREATE_ENTRY or ABORT so we test | ||
that the flow is able to recover from an error. | ||
config-flow: | ||
status: todo | ||
comment: | | ||
1. YAML import to be removed after core team meeting discussion on approach. | ||
2. Consider enhnacement to automatically select a host when multiple are discovered. | ||
3. Move hass.data[heos_discovered_hosts] into hass.data[heos] | ||
dependency-transparency: done | ||
docs-actions: done | ||
docs-high-level-description: done | ||
docs-installation-instructions: done | ||
docs-removal-instructions: todo | ||
entity-event-setup: | ||
status: todo | ||
comment: | | ||
Simplify by using async_on_remove instead of keeping track of listeners to remove | ||
later in async_will_remove_from_hass. | ||
entity-unique-id: done | ||
has-entity-name: done | ||
runtime-data: done | ||
test-before-configure: todo | ||
test-before-setup: done | ||
unique-config-entry: | ||
status: todo | ||
comment: | | ||
The HEOS integration only supports a single config entry, but needs to be migrated to use | ||
the `single_config_entry` flag. HEOS devices interconnect to each other, so connecting to | ||
a single node yields access to all the devices setup with HEOS on your network. The HEOS API | ||
documentation does not recommend connecting to multiple nodes which would provide no bennefit. | ||
# Silver | ||
action-exceptions: | ||
status: todo | ||
comment: Actions currently only log and instead should raise exceptions. | ||
config-entry-unloading: done | ||
docs-configuration-parameters: | ||
status: done | ||
comment: | | ||
The integration doesn't provide any additional configuration parameters. | ||
docs-installation-parameters: done | ||
entity-unavailable: done | ||
integration-owner: done | ||
log-when-unavailable: | ||
status: todo | ||
comment: | | ||
The integration currently spams the logs until reconnected | ||
parallel-updates: | ||
status: todo | ||
comment: Needs to be set to 0. The underlying library handles parallel updates. | ||
reauthentication-flow: | ||
status: exempt | ||
comment: | | ||
This integration doesn't require re-authentication. | ||
test-coverage: | ||
status: todo | ||
comment: | | ||
1. Integration has >95% coverage, however tests need to be updated to not patch internals. | ||
2. test_async_setup_entry_connect_failure and test_async_setup_entry_player_failure -> Instead of | ||
calling async_setup_entry directly, rather use hass.config_entries.async_setup and then assert | ||
the config_entry.state is what we expect. | ||
3. test_unload_entry -> We should use hass.config_entries.async_unload and assert the entry state | ||
4. Recommend using snapshot in test_state_attributes. | ||
5. Find a way to avoid using internal dispatcher in test_updates_from_connection_event. | ||
# Gold | ||
devices: | ||
status: todo | ||
comment: | | ||
The integraiton creates devices, but needs to stringify the id for the device identifier and | ||
also migrate the device. | ||
diagnostics: todo | ||
discovery-update-info: | ||
status: todo | ||
comment: Explore if this is possible. | ||
discovery: done | ||
docs-data-update: todo | ||
docs-examples: todo | ||
docs-known-limitations: todo | ||
docs-supported-devices: todo | ||
docs-supported-functions: done | ||
docs-troubleshooting: | ||
status: todo | ||
comment: Has some troublehsooting setps, but needs to be improved | ||
docs-use-cases: done | ||
dynamic-devices: todo | ||
entity-category: done | ||
entity-device-class: done | ||
entity-disabled-by-default: done | ||
entity-translations: done | ||
exception-translations: todo | ||
icon-translations: done | ||
reconfiguration-flow: todo | ||
repair-issues: todo | ||
stale-devices: todo | ||
# Platinum | ||
async-dependency: done | ||
inject-websession: | ||
status: done | ||
comment: The integration does not use websession | ||
strict-typing: todo |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, is
only there for people using
homeassistant.update_entity
or did I miss a use case here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I did see the
update_before_add=True
inasync_add_entities
. Is that the only moment this is called?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the only place it's called. This was the former guidance for how a push integration should set initial states before getting added. Is there a better way now?