Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set quality scale to silver for Husqvarna Automower #132293

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

Thomas55555
Copy link
Contributor

@Thomas55555 Thomas55555 commented Dec 4, 2024

Breaking change

Proposed change

Mark Husqvarna Automower quality scale as silver. See https://github.com/home-assistant/core/blob/dev/homeassistant/components/husqvarna_automower/quality_scale.yaml

Bronze

  • config-flow - Integration needs to be able to be set up via the UI
    • Uses data-description to give context to fields (via Application credentials integration)
    • Uses ConfigEntry.data and ConfigEntry.options correctly
  • test-before-configure - Test a connection in the config flow
  • unique-config-entry - Don't allow the same device or service to be able to be set up twice
  • config-flow-test-coverage - Full test coverage for the config flow
  • runtime-data - Use ConfigEntry.runtime_data to store runtime data
  • test-before-setup - Check during integration initialization if we are able to set it up correctly
  • appropriate-polling - If it's a polling integration, set an appropriate polling interval
  • entity-unique-id - Entities have a unique ID
  • has-entity-name - Entities use has_entity_name = True
  • entity-event-setup - Entities event setup (Entities of this integration does not explicitly subscribe to events)
  • dependency-transparency - Dependency transparency
  • action-setup - Service actions are registered in async_setup
  • common-modules - Place common patterns in common modules
  • docs-high-level-description - The documentation includes a high-level description of the integration brand, product, or service
  • docs-installation-instructions - The documentation provides step-by-step installation instructions for the integration, including, if needed, prerequisites
  • docs-removal-instructions - The documentation provides removal instructions
  • docs-actions - The documentation describes the provided service actions that can be used
  • brands - Has branding assets available for the integration

Silver

  • config-entry-unloading - Support config entry unloading
  • log-when-unavailable - If internet/device/service is unavailable, log once when unavailable and once when back connected (via coordinator)
  • entity-unavailable - Mark entity unavailable if appropriate
  • action-exceptions - Service actions raise exceptions when encountering failures
  • reauthentication-flow - Reauthentication flow
  • parallel-updates - Set Parallel updates
  • test-coverage - Above 95% test coverage for all integration modules
  • integration-owner - Has an integration owner
  • docs-installation-parameters - The documentation describes all integration installation parameters
  • docs-configuration-parameters - The documentation describes all integration configuration options (no options available)

Needs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Thomas55555 Thomas55555 marked this pull request as ready for review December 4, 2024 19:39
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title says silver, PR says bronze

@home-assistant home-assistant bot marked this pull request as draft December 4, 2024 21:07
@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Thomas55555 Thomas55555 marked this pull request as ready for review December 4, 2024 21:27
@home-assistant home-assistant bot requested a review from joostlek December 4, 2024 21:27
@joostlek joostlek merged commit ad34082 into home-assistant:dev Dec 9, 2024
34 checks passed
@Thomas55555 Thomas55555 deleted the bronze branch December 9, 2024 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants