-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (de)humidifier platform to Honeywell #132287
Conversation
Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's split this into 3 PRs :)
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Testing my GIT skills.... I should rebase this PR after the other 2 are accepted? |
Sure! |
Add strings Fix typos
finish removal of hass.data[domain] usage
83daaac
to
31e778a
Compare
remove static where dynamic exist
Do I need to add tests go get this in? |
They can be added in here, that would work better as we see the full picture |
Name Snapshots
Proposed change
Add (de)humidifier platform to Honeywell
Add tests for humidifier platform
Fix stale docs in tests.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: