Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (de)humidifier platform to Honeywell #132287

Merged
merged 14 commits into from
Dec 18, 2024

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Dec 4, 2024

Proposed change

Add (de)humidifier platform to Honeywell
Add tests for humidifier platform
Fix stale docs in tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration (honeywell) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of honeywell can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign honeywell Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split this into 3 PRs :)

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 4, 2024 18:46
@mkmer
Copy link
Contributor Author

mkmer commented Dec 4, 2024

Testing my GIT skills.... I should rebase this PR after the other 2 are accepted?

@joostlek
Copy link
Member

joostlek commented Dec 4, 2024

Sure!

@mkmer mkmer force-pushed the Honeywell-Humidifiers branch from 83daaac to 31e778a Compare December 4, 2024 21:08
mkmer added 2 commits December 4, 2024 21:12
remove static where dynamic exist
@mkmer
Copy link
Contributor Author

mkmer commented Dec 4, 2024

Do I need to add tests go get this in?
I was planning on adding them in a separate PR, but will add them here if they need to be.

@joostlek
Copy link
Member

joostlek commented Dec 4, 2024

They can be added in here, that would work better as we see the full picture

Fix stale docs
@mkmer mkmer marked this pull request as ready for review December 5, 2024 00:22
@home-assistant home-assistant bot requested a review from joostlek December 5, 2024 00:22
@home-assistant home-assistant bot marked this pull request as draft December 5, 2024 00:26
add refs in strings
snapshot for static vars
@mkmer mkmer marked this pull request as ready for review December 5, 2024 01:19
@home-assistant home-assistant bot requested a review from joostlek December 5, 2024 01:19
@mkmer mkmer marked this pull request as draft December 5, 2024 15:48
@mkmer mkmer marked this pull request as ready for review December 5, 2024 15:55
@home-assistant home-assistant bot marked this pull request as draft December 18, 2024 12:55
Name Snapshots
@mkmer mkmer marked this pull request as ready for review December 18, 2024 13:52
@home-assistant home-assistant bot requested a review from joostlek December 18, 2024 13:52
@joostlek joostlek merged commit c9f1829 into home-assistant:dev Dec 18, 2024
30 checks passed
@mkmer mkmer deleted the Honeywell-Humidifiers branch December 18, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No humidity control?
2 participants