-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata support to Snapcast media players #132283
base: dev
Are you sure you want to change the base?
Conversation
Hey there @luar123, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
The integration or the software/devices? |
The software. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@joostlek Any additional concerns with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think I like to have tests for this so we can be sure that it works like we expect, but that's not a hard requirement
Ok, add some tests to check the metadata properties and some basic media player state. Plenty to expand upon as well. I ended up switching back to |
Update test case to better catch above mistake
@mill1000 would you like any help on this, think this would be a massive value add for a lot of people using the snapcast integration. |
Sure! Any help would be appreciated. I'm not aware of any additional requested changes to this PR. I think it just needs final approval and to be merged. |
Proposed change
Add metadata support to Snapcast media players.
Snapcast streams can contain metadata provided via a stream plugin or natively.
Snapcast includes metadata support for the following sources:
Additionally I have developed a stream plugin for UPnP renderers: https://github.com/mill1000/snapcast-upnp
Example Screenshots

UPnP Stream Plugin
Airplay Native

This is a redo of my original PR #117372 which was split into multiple phases.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: