Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated integration dte_energy_bridge #132276

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Dec 4, 2024

Breaking change

The dte_energy_bridge was removed after 6 months of deperation time. New users can't get any supported devices, and the integration will fail as soon as a current device gets internet access. User were already instructed to remove there configuration from configuration.yaml.

Proposed change

Remove deprecated integration dte_energy_bridge.

PR to remove brand: home-assistant/brands#6168

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@jbouwh jbouwh requested a review from a team as a code owner December 4, 2024 15:32
@epenet
Copy link
Contributor

epenet commented Dec 5, 2024

I assumes this needs docs/brands removal also

@epenet epenet marked this pull request as draft December 5, 2024 10:19
@jbouwh
Copy link
Contributor Author

jbouwh commented Dec 5, 2024

I assumes this needs docs/brands removal also

Docs are already removed AFAIN, but I'll open a brands PR

@jbouwh
Copy link
Contributor Author

jbouwh commented Dec 5, 2024

Updated PR description with PR to remove brand. Docs are already removed. And an URL redirect is active.

@jbouwh jbouwh marked this pull request as ready for review December 5, 2024 20:09
@epenet
Copy link
Contributor

epenet commented Dec 5, 2024

Updated PR description with PR to remove brand. Docs are already removed. And an URL redirect is active.

Found it: home-assistant/home-assistant.io#33395

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbouwh 👍

@gjohansson-ST gjohansson-ST merged commit 3e98df7 into dev Dec 5, 2024
64 checks passed
@gjohansson-ST gjohansson-ST deleted the dte_energy_bridge-cleanup branch December 5, 2024 21:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants