Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yaml import from incomfort integration after deprecation time #132275

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Dec 4, 2024

Breaking change

YAML support for the incomfort integration was removed after 6 months of deprecation. The yaml configfuration was migrated to the UI automatically and users were instructed to remove the imported configuration from configuration.yaml.

Proposed change

Remove yaml import from incomfort integration after deprecation time

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to adjust CONFIG_SCHEMA constant

@home-assistant
Copy link

home-assistant bot commented Dec 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 5, 2024 09:59
@jbouwh
Copy link
Contributor Author

jbouwh commented Dec 5, 2024

CONFIG_SCHEMA

I think you need to adjust CONFIG_SCHEMA constant

Why is this needed, there is no async_setup method any more, so it should not depend on CONFIG_SCHEMA imo.
Shoot, it should be cleaned up.

@jbouwh jbouwh marked this pull request as ready for review December 5, 2024 18:15
@home-assistant home-assistant bot requested a review from epenet December 5, 2024 18:15
@epenet epenet marked this pull request as draft December 5, 2024 19:54
@jbouwh jbouwh marked this pull request as ready for review December 5, 2024 19:57
@home-assistant home-assistant bot requested a review from epenet December 5, 2024 19:57
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jbouwh jbouwh merged commit 5fdd705 into dev Dec 5, 2024
34 checks passed
@jbouwh jbouwh deleted the incomfort-remove-yaml-import branch December 5, 2024 20:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants