-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract file receiver from BackupManager.async_receive_backup
to util
#132271
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
queue.put_nowait((chunk, None)) | ||
continue | ||
|
||
chunk_future = hass.loop.create_future() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: Why is it important to wait until the chunk is written to disk? Is it to not consume the stream in vain and waste resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is strange. It seems like a more obvious solution would be a sempahore initiated at 5 to ensure we don't fill the RAM if http reading is faster than file writing.
We can consider changing this in a follow-up, we should do some performance testing probably.
Co-authored-by: Martin Hjelmare <[email protected]>
Proposed change
Extract file receiver from
BackupManager.async_receive_backup
to improve core readability and allowing it to be reusedType of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: