Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-before-setup rule to quality_scale validation #132255

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Dec 4, 2024

Proposed change

Spotted in #132227
Documented in https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/test-before-setup/

Needs:

Integrations: 1304
Invalid integrations: 1

Found errors. Generating files canceled.

Integration mqtt:
* [ERROR] [QUALITY_SCALE] [test-before-setup] Integration does not raise one of {'ConfigEntryAuthFailed', 'ConfigEntryNotReady', 'ConfigEntryError'} in async_setup_entry (homeassistant/components/mqtt/__init__.py)
* [ERROR] [QUALITY_SCALE] Please check the documentation at https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/test-before-setup/

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 4, 2024

Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for MQTT,
Thanks @epenet 👍

@epenet epenet marked this pull request as draft December 5, 2024 06:54
@epenet epenet force-pushed the epenet-20241204-1152 branch 2 times, most recently from 0b2da60 to 64c4469 Compare December 5, 2024 19:58
@epenet epenet marked this pull request as ready for review December 5, 2024 19:58
@epenet epenet force-pushed the epenet-20241204-1152 branch 4 times, most recently from 966ed5c to 500b655 Compare December 10, 2024 14:33
@epenet epenet marked this pull request as draft December 11, 2024 08:11
@epenet epenet force-pushed the epenet-20241204-1152 branch from e66596a to a94d15f Compare December 11, 2024 09:18
@epenet epenet marked this pull request as ready for review December 11, 2024 09:21
@epenet epenet force-pushed the epenet-20241204-1152 branch from a94d15f to e415467 Compare December 12, 2024 15:57
@epenet epenet merged commit 2cff752 into dev Dec 12, 2024
64 checks passed
@epenet epenet deleted the epenet-20241204-1152 branch December 12, 2024 21:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants