-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test-before-setup rule to quality_scale validation #132255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epenet
requested review from
emontnemery,
jbouwh,
bdraco and
a team
as code owners
December 4, 2024 10:54
home-assistant
bot
added
cla-signed
core
integration: mqtt
new-feature
small-pr
PRs with less than 30 lines.
quality-scale
labels
Dec 4, 2024
Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
epenet
commented
Dec 4, 2024
jbouwh
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for MQTT,
Thanks @epenet 👍
19 tasks
epenet
force-pushed
the
epenet-20241204-1152
branch
2 times, most recently
from
December 5, 2024 19:58
0b2da60
to
64c4469
Compare
epenet
force-pushed
the
epenet-20241204-1152
branch
4 times, most recently
from
December 10, 2024 14:33
966ed5c
to
500b655
Compare
epenet
force-pushed
the
epenet-20241204-1152
branch
from
December 11, 2024 09:18
e66596a
to
a94d15f
Compare
epenet
force-pushed
the
epenet-20241204-1152
branch
from
December 12, 2024 15:57
a94d15f
to
e415467
Compare
gjohansson-ST
approved these changes
Dec 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
core
integration: mqtt
new-feature
Quality Scale: No score
quality-scale
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Spotted in #132227
Documented in https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/test-before-setup/
Needs:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: