Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump pip freeze in CI #132173

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Dump pip freeze in CI #132173

merged 5 commits into from
Dec 3, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Dec 3, 2024

Proposed change

Should help with future instances of deep-nested dependencies causing CI to break
See #132170

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet epenet requested a review from a team as a code owner December 3, 2024 13:04
@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Dec 3, 2024
Comment on lines 533 to 538
- name: Dump pip freeze
run: |
python -m venv venv
. venv/bin/activate
python --version
uv pip freeze
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not dump it in the logs, but instead attach it to CI job as an artifact.

@home-assistant home-assistant bot marked this pull request as draft December 3, 2024 13:08
@home-assistant
Copy link

home-assistant bot commented Dec 3, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@epenet epenet marked this pull request as ready for review December 3, 2024 13:59
@home-assistant home-assistant bot requested a review from frenck December 3, 2024 13:59
@epenet epenet merged commit 6fc4f45 into home-assistant:dev Dec 3, 2024
59 of 61 checks passed
@epenet epenet deleted the epenet-20241203-1402 branch December 3, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants