Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'state_class' attribute for Growatt plant sensors #132145

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

LaithBudairi
Copy link
Contributor

Proposed change

This PR adds missing 'state_class' attribute for the sensor entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

epenet
epenet previously requested changes Dec 3, 2024
@home-assistant home-assistant bot marked this pull request as draft December 3, 2024 08:34
@home-assistant
Copy link

home-assistant bot commented Dec 3, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@LaithBudairi LaithBudairi marked this pull request as ready for review December 3, 2024 10:07
@home-assistant home-assistant bot requested a review from epenet December 3, 2024 10:07
zweckj
zweckj previously requested changes Dec 16, 2024
@home-assistant home-assistant bot marked this pull request as draft December 16, 2024 20:10
@LaithBudairi LaithBudairi marked this pull request as ready for review December 23, 2024 09:36
@home-assistant home-assistant bot requested a review from zweckj December 23, 2024 09:37
@home-assistant home-assistant bot marked this pull request as draft December 23, 2024 21:53
@LaithBudairi LaithBudairi marked this pull request as ready for review December 24, 2024 10:54
@home-assistant home-assistant bot requested a review from frenck December 24, 2024 10:54
@frenck
Copy link
Member

frenck commented Jan 17, 2025

I've marked this PR as draft, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

@frenck frenck marked this pull request as draft January 17, 2025 07:43
@frenck frenck marked this pull request as ready for review February 28, 2025 22:31
@home-assistant home-assistant bot requested a review from zweckj February 28, 2025 22:31
@home-assistant home-assistant bot requested a review from frenck February 28, 2025 22:31
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Feb 28, 2025
@frenck frenck added this to the 2025.3.0 milestone Feb 28, 2025
@frenck frenck dismissed zweckj’s stale review February 28, 2025 22:58

Comment addressed

@frenck frenck merged commit 615d79b into home-assistant:dev Feb 28, 2025
32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cherry-picked cla-signed integration: growatt_server Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State class for Growatt plant sensors is missing
5 participants