Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hassil and intents #132092

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Bump hassil and intents #132092

merged 1 commit into from
Dec 2, 2024

Conversation

synesthesiam
Copy link
Contributor

Breaking change

Proposed change

Bump intents: home-assistant/intents@2024.11.27...2024.12.2
Bump hassil: home-assistant/hassil@v2.0.4...v2.0.5

The new intents exposed two bugs:

  • New "skip words" were added to English, which were part of the test sentence templates ("I'd like to order {beer_style}"). This will ultimately need to be fixed in hassil, so for the beta the test template has simply been changed.
  • New floor sentences unearthed a small bug regarding how literal matched text is counted when intent matching initially fails. This resulted in the wrong error message, and required a small change in hassil.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 2, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@synesthesiam synesthesiam added this to the 2024.12.0 milestone Dec 2, 2024
@balloob balloob merged commit e521829 into dev Dec 2, 2024
59 of 61 checks passed
@balloob balloob deleted the synesthesiam-20241202-intent-bump branch December 2, 2024 19:09
@balloob balloob mentioned this pull request Dec 3, 2024
19 tasks
epenet added a commit that referenced this pull request Dec 3, 2024
@epenet epenet mentioned this pull request Dec 3, 2024
19 tasks
MartinHjelmare pushed a commit that referenced this pull request Dec 3, 2024
* Revert "Fix bad hassil tests on CI (#132132)"

This reverts commit 101bb09.

* Revert "Bump hassil and intents (#132092)"

This reverts commit e521829.
@MartinHjelmare MartinHjelmare removed this from the 2024.12.0 milestone Dec 3, 2024
@epenet epenet added this to the 2024.12.0 milestone Dec 3, 2024
@epenet
Copy link
Contributor

epenet commented Dec 3, 2024

I've added back to milestone as CI failure was unrelated

frenck pushed a commit that referenced this pull request Dec 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants