Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate new httpx client for lamarzocco #132016

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

zweckj
Copy link
Member

@zweckj zweckj commented Dec 1, 2024

Breaking change

Proposed change

lamarzocco's servers are picky concerning the traffic it accepts and will block if anything is injected that is not following their definition. Theirfore don't use the centralized client, but use a new one.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zweckj zweckj changed the title DNM: New client test for lamarzocco Instantiate new httpx client for lamarzocco Dec 2, 2024
@zweckj zweckj requested a review from epenet December 2, 2024 10:08
@zweckj
Copy link
Member Author

zweckj commented Dec 2, 2024

please add to 2024.12

@zweckj zweckj marked this pull request as ready for review December 2, 2024 10:18
@epenet epenet added this to the 2024.12.0 milestone Dec 2, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @zweckj 👍

../Frenck

@frenck frenck merged commit e3885b8 into home-assistant:dev Dec 3, 2024
34 checks passed
@zweckj zweckj deleted the lamarzocco/create-client branch December 3, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lamarzocco Integration: Setup fail with http error 400
3 participants