Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translated native unit of measurement - PiHole #131915

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Add translated native unit of measurement - PiHole #131915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 5 additions & 24 deletions homeassistant/components/pi_hole/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
SensorEntityDescription(
key="ads_blocked_today",
translation_key="ads_blocked_today",
native_unit_of_measurement="ads",
),
SensorEntityDescription(
key="ads_percentage_today",
Expand All @@ -28,38 +27,20 @@
SensorEntityDescription(
key="clients_ever_seen",
translation_key="clients_ever_seen",
native_unit_of_measurement="clients",
),
SensorEntityDescription(
key="dns_queries_today",
translation_key="dns_queries_today",
native_unit_of_measurement="queries",
key="dns_queries_today", translation_key="dns_queries_today"
),
SensorEntityDescription(
key="domains_being_blocked",
translation_key="domains_being_blocked",
native_unit_of_measurement="domains",
),
SensorEntityDescription(key="queries_cached", translation_key="queries_cached"),
SensorEntityDescription(
key="queries_cached",
translation_key="queries_cached",
native_unit_of_measurement="queries",
),
SensorEntityDescription(
key="queries_forwarded",
translation_key="queries_forwarded",
native_unit_of_measurement="queries",
),
SensorEntityDescription(
key="unique_clients",
translation_key="unique_clients",
native_unit_of_measurement="clients",
),
SensorEntityDescription(
key="unique_domains",
translation_key="unique_domains",
native_unit_of_measurement="domains",
key="queries_forwarded", translation_key="queries_forwarded"
),
SensorEntityDescription(key="unique_clients", translation_key="unique_clients"),
SensorEntityDescription(key="unique_domains", translation_key="unique_domains"),
)


Expand Down
24 changes: 16 additions & 8 deletions homeassistant/components/pi_hole/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,31 +41,39 @@
},
"sensor": {
"ads_blocked_today": {
"name": "Ads blocked today"
"name": "Ads blocked today",
"unit_of_measurement": "ads"
},
"ads_percentage_today": {
"name": "Ads percentage blocked today"
},
"clients_ever_seen": {
"name": "Seen clients"
"name": "Seen clients",
"unit_of_measurement": "clients"
},
"dns_queries_today": {
"name": "DNS queries today"
"name": "DNS queries today",
"unit_of_measurement": "queries"
},
"domains_being_blocked": {
"name": "Domains blocked"
"name": "Domains blocked",
"unit_of_measurement": "domains"
},
"queries_cached": {
"name": "DNS queries cached"
"name": "DNS queries cached",
"unit_of_measurement": "[%key:component::pi_hole::entity::sensor::dns_queries_today::unit_of_measurement%]"
},
"queries_forwarded": {
"name": "DNS queries forwarded"
"name": "DNS queries forwarded",
"unit_of_measurement": "[%key:component::pi_hole::entity::sensor::dns_queries_today::unit_of_measurement%]"
},
"unique_clients": {
"name": "DNS unique clients"
"name": "DNS unique clients",
"unit_of_measurement": "[%key:component::pi_hole::entity::sensor::clients_ever_seen::unit_of_measurement%]"
},
"unique_domains": {
"name": "DNS unique domains"
"name": "DNS unique domains",
"unit_of_measurement": "[%key:component::pi_hole::entity::sensor::domains_being_blocked::unit_of_measurement%]"
}
},
"update": {
Expand Down