-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump elmax-api to 0.0.6.3 #131876
Bump elmax-api to 0.0.6.3 #131876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sanity check 0.0.6.3 ✔️
Please fix the CI, there is an error with the elmax tests
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
f39f9bc
to
a8d1453
Compare
@edenhaus , I believe the CI is broken: tests do pass locally. Moreover, it seems tests that fail are not related to elmax component. Can you please check? |
fd89542
to
e5a7300
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests for this integration are failing now. Can you take a look?
Thanks! 👍
../Frenck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong button... still early day for me ☕
Trying again :)
d0d77c4
to
b9f9891
Compare
Hi! Yup, I had to update a fixture to align with the low-level library checking the expiration of the mocked JWT. |
test failure unrelated |
Breaking change
None.
Proposed change
What changed:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: