Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump elmax-api to 0.0.6.3 #131876

Merged

Conversation

albertogeniola
Copy link
Contributor

@albertogeniola albertogeniola commented Nov 28, 2024

Breaking change

None.

Proposed change

  • Fix the integration setup issue when targeting a local-panel (username key error).
  • Upgrade low-level library dependency from v0.0.6.1 to v0.0.6.3rc2. Changelog here.
    What changed:
# 0.0.6.3rc2
- Implement refresh token api
- Improve websocket connection handling
- Reduce wait time before reconnecting to websocket in case of connection drop

# v0.0.6.2
- Fix wrong protocol check to better handle https/wss endpoints with SSL
- Handle pipy dependency to explicitly point to the new asyncio implementation

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@edenhaus edenhaus changed the title Elmax/fix direct connect Bump elmax-api to 0.0.6.3 Dec 2, 2024
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check 0.0.6.3 ✔️

Please fix the CI, there is an error with the elmax tests

@home-assistant
Copy link

home-assistant bot commented Dec 2, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 2, 2024 10:04
@edenhaus edenhaus added this to the 2024.12.0 milestone Dec 2, 2024
@albertogeniola albertogeniola force-pushed the elmax/fix_direct_connect branch 2 times, most recently from f39f9bc to a8d1453 Compare December 2, 2024 22:22
@albertogeniola
Copy link
Contributor Author

albertogeniola commented Dec 2, 2024

Sanity check 0.0.6.3 ✔️

Please fix the CI, there is an error with the elmax tests

@edenhaus , I believe the CI is broken: tests do pass locally. Moreover, it seems tests that fail are not related to elmax component. Can you please check?

@albertogeniola albertogeniola force-pushed the elmax/fix_direct_connect branch 2 times, most recently from fd89542 to e5a7300 Compare December 3, 2024 22:18
@albertogeniola albertogeniola marked this pull request as ready for review December 3, 2024 23:18
@home-assistant home-assistant bot requested a review from edenhaus December 3, 2024 23:18
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests for this integration are failing now. Can you take a look?

Thanks! 👍

../Frenck

frenck
frenck previously requested changes Dec 4, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button... still early day for me ☕

Trying again :)

@home-assistant home-assistant bot marked this pull request as draft December 4, 2024 08:55
@albertogeniola albertogeniola force-pushed the elmax/fix_direct_connect branch from d0d77c4 to b9f9891 Compare December 4, 2024 22:04
@albertogeniola albertogeniola marked this pull request as ready for review December 4, 2024 22:47
@home-assistant home-assistant bot requested a review from frenck December 4, 2024 22:47
@albertogeniola
Copy link
Contributor Author

Hi! Yup, I had to update a fixture to align with the low-level library checking the expiration of the mocked JWT.
Tests for ELMAX do pass now (both locally and in CI), although there is a failed - unrelated - test for the zha integration.

@edenhaus
Copy link
Contributor

edenhaus commented Dec 4, 2024

test failure unrelated

@edenhaus edenhaus merged commit 84e6c0b into home-assistant:dev Dec 4, 2024
60 of 61 checks passed
@edenhaus edenhaus modified the milestones: 2024.12.0, 2024.12.1 Dec 4, 2024
zweckj pushed a commit to zweckj/home-assistant-core that referenced this pull request Dec 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
@albertogeniola albertogeniola deleted the elmax/fix_direct_connect branch December 7, 2024 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elmax - Error when adding direct panel without discovery
3 participants