Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buienradar sensors only after being added to HA #131830

Merged
merged 7 commits into from
Dec 2, 2024

Conversation

abmantis
Copy link
Contributor

Breaking change

Proposed change

The state of the entities was being updated before they were added to HA. They were also updated even when they were disabled. Both conditions caused a failure since platform was not set for the entity, which is required for the translated unit of measurement.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @mjj4791, @ties, @RobBie1221, mind taking a look at this pull request as it has been labeled with an integration (buienradar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of buienradar can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign buienradar Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@emontnemery
Copy link
Contributor

emontnemery commented Nov 28, 2024

I think we need to handle this case in the base class

@abmantis
Copy link
Contributor Author

I think we need to handle this case in the base class

Since the issue is the call to SensorEntity.state, should we do a check there and raise? That means we still need this changes on the integration, otherwise it will fail there.

@abmantis abmantis marked this pull request as draft November 28, 2024 16:06
@abmantis abmantis marked this pull request as ready for review November 28, 2024 19:13
@abmantis abmantis requested a review from a team as a code owner November 28, 2024 19:13
@home-assistant home-assistant bot marked this pull request as draft November 28, 2024 21:40
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@catsmanac
Copy link
Contributor

fwiw, if I run the pr branch the original error does no longer show.

@abmantis abmantis marked this pull request as ready for review December 2, 2024 11:57
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2024.12.0 milestone Dec 2, 2024
@MartinHjelmare MartinHjelmare merged commit 6db8fce into dev Dec 2, 2024
63 of 64 checks passed
@MartinHjelmare MartinHjelmare deleted the buienradar_state_update_fix branch December 2, 2024 12:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buienradar in 2024.12.0 : NoneType' object has no attribute 'platform_name'
5 participants