Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Home Connect microwave programs #131782

Merged

Conversation

TheJulianJES
Copy link
Member

@TheJulianJES TheJulianJES commented Nov 28, 2024

Proposed change

This adds a missing dot to the microwave program strings in the translation key map for the select entity in the Home Connect integration. Official docs also confirm this is the correct string and the fix works for me.

The bsh_key_to_translation_key function still returns the same result after the program string change, so the translation keys do not need to be updated.

I do wonder if the error below should have been handled more gracefully? If so, that's for a separate PR though.
Noticed this in the logs after upgrading to Home Assistant Core 2024.12.0b0:

2024-11-28 01:32:19.779 INFO (SyncWorker_5) [homeassistant.components.home_connect.select] The program "Cooking.Oven.Program.Microwave.90Watt" is not part of the official Home Connect API specification
2024-11-28 01:32:19.779 INFO (SyncWorker_5) [homeassistant.components.home_connect.select] The program "Cooking.Oven.Program.Microwave.360Watt" is not part of the official Home Connect API specification
2024-11-28 01:32:19.788 ERROR (MainThread) [homeassistant.components.select] Error while setting up home_connect platform for select
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 366, in _async_setup_platform
    await asyncio.shield(awaitable)
  File "/usr/src/homeassistant/homeassistant/components/home_connect/select.py", line 237, in async_setup_entry
    async_add_entities(await hass.async_add_executor_job(get_entities), True)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/homeassistant/homeassistant/components/home_connect/select.py", line 231, in get_entities
    entities.extend(
    ~~~~~~~~~~~~~~~^
        HomeConnectProgramSelectEntity(device, programs, desc)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        for desc in PROGRAM_SELECT_ENTITY_DESCRIPTIONS
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/usr/src/homeassistant/homeassistant/components/home_connect/select.py", line 232, in <genexpr>
    HomeConnectProgramSelectEntity(device, programs, desc)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/home_connect/select.py", line 255, in __init__
    PROGRAMS_TRANSLATION_KEYS_MAP[program] for program in programs
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
KeyError: 'Cooking.Oven.Program.Microwave.180Watt'

Nice job on all the recent updates to Home Connect btw!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @DavidMStraub, @Diegorro98, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of home_connect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign home_connect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@Diegorro98 Diegorro98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you very much for seeing this issue and correcting it :)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TheJulianJES 👍

../Frenck

@frenck frenck merged commit 0f5e0dd into home-assistant:dev Nov 28, 2024
34 checks passed
frenck pushed a commit that referenced this pull request Nov 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants