-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data/data_description translation checks #131705
Conversation
cc @konikvranik, @allenporter for |
cc @zweckj for |
cc @cgarwood for |
cc @Ernst79, @dontinelli for |
|
PR pending: #131712 |
#131716 for Fully Kiosk It appears that data descriptions do not show up in the frontend for boolean/checkbox fields. |
Interesting... should this be raised as a bug in frontend? or should it be removed from the check here? |
8eb0144
to
07c8f59
Compare
@CoMPaTech @bouwew please take look at plugwise issues |
|
07c8f59
to
979c5e2
Compare
979c5e2
to
a284c02
Compare
@miaucl, @tr4nt0r there are new violations for
|
@arturpragacz there are new violations for
|
The input source names in Onkyo should not be translated, as they are international by nature. They should also not have any individual descriptions. |
a284c02
to
6351037
Compare
6351037
to
cc5bbbb
Compare
I've added "ignore_translations" for this use case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @epenet 👍
../Frenck
Proposed change
Based on https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/config-flow,
data
anddata_description
are compulsory for every schema field.Needs:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: