Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data/data_description translation checks #131705

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Add data/data_description translation checks #131705

merged 2 commits into from
Dec 13, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Nov 27, 2024

Proposed change

Based on https://developers.home-assistant.io/docs/core/integration-quality-scale/rules/config-flow, data and data_description are compulsory for every schema field.

Needs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor Author

epenet commented Nov 27, 2024

cc @konikvranik, @allenporter for rainbird

@epenet
Copy link
Contributor Author

epenet commented Nov 27, 2024

cc @zweckj for lamarzocco

@epenet
Copy link
Contributor Author

epenet commented Nov 27, 2024

cc @cgarwood for fully_kiosk

@epenet
Copy link
Contributor Author

epenet commented Nov 27, 2024

cc @Ernst79, @dontinelli for solarlog

@epenet
Copy link
Contributor Author

epenet commented Nov 27, 2024

renault should be handled in #131706

@zweckj
Copy link
Member

zweckj commented Nov 27, 2024

cc @zweckj for lamarzocco

@epenet should be through #131708

@dontinelli
Copy link
Contributor

cc @Ernst79, @dontinelli for solarlog

PR pending: #131712

@cgarwood
Copy link
Member

#131716 for Fully Kiosk

It appears that data descriptions do not show up in the frontend for boolean/checkbox fields.

@epenet
Copy link
Contributor Author

epenet commented Nov 27, 2024

#131716 for Fully Kiosk

It appears that data descriptions do not show up in the frontend for boolean/checkbox fields.

Interesting... should this be raised as a bug in frontend? or should it be removed from the check here?

@epenet epenet force-pushed the epenet-20241127-1208 branch 2 times, most recently from 8eb0144 to 07c8f59 Compare December 4, 2024 05:31
@epenet
Copy link
Contributor Author

epenet commented Dec 4, 2024

@CoMPaTech @bouwew please take look at plugwise issues

@epenet epenet mentioned this pull request Dec 4, 2024
19 tasks
@CoMPaTech CoMPaTech mentioned this pull request Dec 4, 2024
19 tasks
@CoMPaTech
Copy link
Contributor

@CoMPaTech @bouwew please take look at plugwise issues

@epenet drafting #132239

@epenet epenet force-pushed the epenet-20241127-1208 branch from 07c8f59 to 979c5e2 Compare December 6, 2024 21:58
@epenet epenet marked this pull request as ready for review December 6, 2024 21:58
@epenet epenet force-pushed the epenet-20241127-1208 branch from 979c5e2 to a284c02 Compare December 9, 2024 09:42
@epenet
Copy link
Contributor Author

epenet commented Dec 10, 2024

@miaucl, @tr4nt0r there are new violations for bring, could you take a look?

=========================== short test summary info ============================
ERROR tests/components/bring/test_init.py::test_init_failure[BringAuthException-ConfigEntryState.SETUP_ERROR] - Failed: Translation not found for bring: `config.step.reauth_confirm.data_description.email`. Please add to homeassistant/components/bring/strings.json
ERROR tests/components/bring/test_config_flow.py::test_flow_user_init_data_already_configured - Failed: Translation not found for bring: `config.step.user.data_description.email`. Please add to homeassistant/components/bring/strings.json
ERROR tests/components/bring/test_config_flow.py::test_flow_reauth - Failed: Translation not found for bring: `config.step.reauth_confirm.data_description.email`. Please add to homeassistant/components/bring/strings.json
ERROR tests/components/bring/test_config_flow.py::test_flow_reauth_unique_id_mismatch - Failed: Translation not found for bring: `config.step.reauth_confirm.data_description.email`. Please add to homeassistant/components/bring/strings.json

@epenet
Copy link
Contributor Author

epenet commented Dec 10, 2024

@arturpragacz there are new violations for onkyo, could you take a look?

=========================== short test summary info ============================
ERROR tests/components/onkyo/test_config_flow.py::test_options_flow - Failed: Translation not found for onkyo: `options.step.init.data.TV`. Please add to homeassistant/components/onkyo/strings.json

@arturpragacz
Copy link
Contributor

The input source names in Onkyo should not be translated, as they are international by nature. They should also not have any individual descriptions.

@epenet epenet force-pushed the epenet-20241127-1208 branch from a284c02 to 6351037 Compare December 12, 2024 20:29
@epenet epenet force-pushed the epenet-20241127-1208 branch from 6351037 to cc5bbbb Compare December 12, 2024 21:19
@epenet
Copy link
Contributor Author

epenet commented Dec 12, 2024

The input source names in Onkyo should not be translated, as they are international by nature. They should also not have any individual descriptions.

I've added "ignore_translations" for this use case

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

../Frenck

@frenck frenck merged commit 8b579d8 into dev Dec 13, 2024
58 of 60 checks passed
@frenck frenck deleted the epenet-20241127-1208 branch December 13, 2024 08:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants